Add schema descriptions for runs-on and concurrency fields#2819
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Added description to top-level runs-on field explaining it's a GitHub Actions standard field typically configured at job level - Added description to top-level concurrency field explaining it's a GitHub Actions standard field with enhanced management in agentic workflows - Both descriptions are intentionally minimal per @pelikhan's guidance "by design" - Schema validates correctly and all workflows compile successfully Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add missing descriptions for runs-on and concurrency in workflow schema
Add schema descriptions for runs-on and concurrency fields
Oct 30, 2025
pelikhan
approved these changes
Oct 30, 2025
Collaborator
|
@copilot make fmt |
Contributor
|
Agentic Changeset Generator triggered by this pull request. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves formatting consistency in JSON schema files and updates GitHub Actions dependency references to specific commit hashes.
- Reformats multi-value enum and default arrays in workflow schemas to use one value per line for better readability
- Adds descriptive documentation for
runs-onandconcurrencyfields in the main workflow schema - Updates
actions/setup-nodeaction references across workflow files to newer commit hashes
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/schemas/github-workflow.json | Reformatted enum and default arrays for workflow event types to multi-line format |
| pkg/parser/schemas/main_workflow_schema.json | Added descriptions for runs-on and concurrency fields |
| .github/workflows/unbloat-docs.lock.yml | Updated actions/setup-node to commit hash 2028fbc5c25fe9cf00d9f06a71cc4710d4507903 |
| .github/workflows/tidy.lock.yml | Updated actions/setup-node to commit hash a0853c24544627f65ddf259abe73b1d18a591444 |
| .github/workflows/technical-doc-writer.lock.yml | Updated actions/setup-node to commit hash a0853c24544627f65ddf259abe73b1d18a591444 |
| .github/workflows/go-logger.lock.yml | Updated actions/setup-node to commit hash a0853c24544627f65ddf259abe73b1d18a591444 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 | ||
| - name: Setup Node.js | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 | ||
| uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 |
There was a problem hiding this comment.
The commit hash 2028fbc5c25fe9cf00d9f06a71cc4710d4507903 is different from the hash used in the other workflow files (a0853c24544627f65ddf259abe73b1d18a591444). Unless there's a specific reason for this difference, all workflows should use the same version for consistency.
Suggested change
| uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 | |
| uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add schema descriptions for runs-on and concurrency fields ✅
Summary
Successfully added minimal, neutral descriptions to the
runs-onandconcurrencytop-level fields in the workflow schema, following @pelikhan's guidance "This is by design. Add documentation to not report this anymore."Changes Made
runs-onfieldconcurrencyfieldmake fmtto format codeImplementation Details
runs-on Field
Added description: "Runner type for workflow execution (GitHub Actions standard field). Typically configured at the job level instead."
This acknowledges the field exists as a standard GitHub Actions property but indicates it's more commonly configured at the job level rather than the top workflow level in agentic workflows.
concurrency Field
Added description: "Concurrency control to limit concurrent workflow runs (GitHub Actions standard field). Agentic workflows use enhanced concurrency management."
This acknowledges the field exists as a standard GitHub Actions property and notes that agentic workflows have their own enhanced concurrency handling, making manual configuration often unnecessary.
Design Philosophy
The descriptions are intentionally minimal and neutral, avoiding promotion of these fields at the top level while documenting their existence. This aligns with the project's design where these fields are better used at the job level or handled automatically by agentic workflow features.
Validation Results
✅ JSON schema validates correctly
✅ Build succeeds with embedded schema
✅ All 60 workflows compile successfully (0 errors, 13 warnings)
✅ Test workflows with both fields work correctly
✅ Python validation confirms descriptions are present
✅ No breaking changes to existing functionality
✅ Code formatted with
make fmtFiles Modified
pkg/parser/schemas/main_workflow_schema.json(2 description lines added)pkg/workflow/schemas/github-workflow.json(formatting applied)Original prompt
runs-onandconcurrencyin workflow schema #2753💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.